Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAYA-107167 - Keep USDZ texture paths relative #865

Merged
merged 2 commits into from
Oct 26, 2020

Conversation

JGamache-autodesk
Copy link
Collaborator

If the path requires a relationship to resolves, we keep it relative.
Fixes #795

If the path requires a relationship to resolves, we keep it relative.
Fixes #795
Copy link
Contributor

@mattyjams mattyjams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a utility function available in the Ar library that we should use instead of the test that's there now. Otherwise, these changes make sense to me.

But I'm not seeing how this change addresses #795. That issue has to do with export, and this only deals with import. I would guess that it's the stuff here that @dgovil is talking about needing to bypass in order to see the desired asset paths in the exported package?:

boost::filesystem::path usdDir(GetUsdStage()->GetRootLayer()->GetRealPath());

lib/usd/translators/shading/usdUVTextureReader.cpp Outdated Show resolved Hide resolved
@JGamache-autodesk
Copy link
Collaborator Author

I missed the "We are still using pxrUSD.bundle to do our exporting.". I will re-check and fix that code path.

@dgovil
Copy link
Collaborator

dgovil commented Oct 26, 2020

Thanks for fixing up the pxrUSD.bundle too! We're about to transition to the mayaUSD.bundle now so hopefully I won't be an imposition on y'all for much longer in that regard, but this will be great for all our code that still calls the pixar export command instead (so hard to track down code across multiple teams and get them all ported)

@JGamache-autodesk JGamache-autodesk added the ready-for-merge Development process is finished, PR is ready for merge label Oct 26, 2020
@kxl-adsk kxl-adsk merged commit 10834d8 into dev Oct 26, 2020
@kxl-adsk kxl-adsk deleted the t_gamaj/MAYA-107167/handle_usdz branch October 26, 2020 19:01
mattyjams added a commit to mattyjams/maya-usd that referenced this pull request Nov 2, 2020
The existing call to usdTranslatorImport_SetOptionMenuByAnnotation() was
replaced with a call to usdTranslatorImport_SetShadingOptionMenuByAnnotation()
in Autodesk#865, but the latter does not exist anywhere. This reverts that change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
import-export Related to Import and/or Export ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MAYA-107167] USDZ export writes paths that aren't inclusive to the usdz
5 participants