Restore session layer properly or create one when root-layer is not editable. #899
Conversation
lib/mayaUsd/nodes/stageNode.cpp
Outdated
| @@ -109,7 +109,10 @@ MStatus UsdMayaStageNode::compute(const MPlug& plug, MDataBlock& dataBlock) | |||
| UsdStageCacheContext ctx(UsdMayaStageCache::Get(loadAll)); | |||
| usdStage = UsdStage::Open(rootLayer, ArGetResolver().GetCurrentContext()); | |||
There was a problem hiding this comment.
I would think similar to what's in proxyShapeBase.cpp, we should probably be checking permissions and possibly creating the sessionLayer first, and then use the Open() overload that takes a sessionLayer if we created one. Otherwise the anonymous layer created below is not part of the stage's layer stack.
|
@marsupial thank you for reporting an issue and opening a pull-request to address it. We have a tricky situation here, since the change of the default edit target was requested internally (and merged with #661). Let's have a conversation on the issue first to make sure we have a solution that works for all stakeholders. |
kxl-adsk
added
do-not-merge-yet
marsupial
force-pushed
the
PR/898-restore-editability
branch
from
90aafab
to
4e7da99
Compare
marsupial
force-pushed
the
PR/898-restore-editability
branch
from
4e7da99
to
14dde13
Compare
|
Update with comments from #898 |
kxl-adsk
removed
the
do-not-merge-yet
marsupial
force-pushed
the
PR/898-restore-editability
branch
from
14dde13
to
eca8845
Compare
kxl-adsk
added
the
ready-for-merge
| // limitations under the License. | ||
| // | ||
|
|
||
| #pragma once |
There was a problem hiding this comment.
The coding guidelines would suggest #include-style guards rather than #pragma once.
| // Convenience to convert a TfToken to MString | ||
| // | ||
| static inline MString toMString(const TfToken& token) | ||
| { | ||
| return MString(token.data(), token.size()); | ||
| } |
There was a problem hiding this comment.
A helper for this actually exists already as UsdMayaUtil::convert():
maya-usd/lib/mayaUsd/utils/util.h
Line 514 in d76c4a0
|
Already been merged, so function-removal and guard changes: #935 |
No description provided.