rename hdMaya back to hdmaya #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
much of the code still used the "hdmaya" folder for includes - likely, this worked on windows (due to case insensitivity), but fails on linux also, this will make merging in outstanding changes from hdmaya much easier
|
We have this change already in our internal refactoring_sandbox branch. We kept the name in source code camel-cased (e.g hdMaya) to match the subdirectory name. |
|
The conflict needs to be resolved in order to merge this PR. This is caused by us following camel-case |
|
If you're going with hdMaya instead of hdmaya (and you've already made this fix in update_refactoring_sandbox), then I'm just going to close this PR |
mattyjams
pushed a commit
to mattyjams/maya-usd
that referenced
this pull request
Sep 26, 2019
Sync with USD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
much of the code still used the lowercase "hdmaya" folder for includes - likely, this
worked on windows (due to case insensitivity), but fails on linux
also, this will make merging in outstanding changes from hdmaya much easier