Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Boost_NO_BOOST_CMAKE=ON for Boost::python #912

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

dgovil
Copy link
Collaborator

@dgovil dgovil commented Nov 11, 2020

This PR is a reflection of our internal changes to support Boost_NO_BOOST_CMAKE=ON for using boost::python along custom paths.

For a set of Boost Versions, the CMake setup made it difficult to use your own Boost library paths.
Prior to Boost 1.70, certain versions of CMake failed to find Boosts Python library due to the addition of version suffixes.
From Boost 1.70 onwards, it is possible for Boost to optionally support CMake files, but can also be problematic if you want to sub in your own paths. Occasionally without Boost_NO_BOOST_CMAKE, CMake will resolve to other versions of boost even if you specify an explicit boost root path. Hence the need for Boost_NO_BOOST_CMAKE.
See https://stackoverflow.com/a/63094072 for more details.

This doesn't appear to affect any other of the Boost requirements for Maya USD, and so we only manage that one specific library here.

@kxl-adsk kxl-adsk added the build Related to building maya-usd repository label Nov 11, 2020
Copy link
Contributor

@HamedSabri-adsk HamedSabri-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thank you.

We have had many headaches with Boost python in the past and it's a bit disappointing that we have to go through all these troubles.

@HamedSabri-adsk HamedSabri-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Nov 12, 2020
@kxl-adsk kxl-adsk merged commit e9c40a7 into Autodesk:dev Nov 12, 2020
@dgovil dgovil deleted the support_no_boost_cmake branch November 20, 2020 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to building maya-usd repository ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants