Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAYA-107600 - UFE/MEL - make select command UFE aware #921

Merged

Conversation

seando-adsk
Copy link
Collaborator

MAYA-107600 - UFE/MEL - make select command UFE aware

  • Updated UFE Selection test now that Maya select command supports UFE.

* Updated UFE Selection test now that Maya select command
  supports UFE.
@seando-adsk seando-adsk requested a review from ppt-adsk November 16, 2020 16:04
self.items = [ufe.Hierarchy.createItem(p) for p in paths]

# Clear selection to start off
cmds.select(clear=True)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the block above from the test into the setUp() method so it will be called by each test (including my new one). I store the created scene items.

sn = ufe.Selection()
sn.append(item)
ufeSelectCmd.replaceWith(sn)
cmds.select(ufe.PathString.string(item.path()))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to use ufeSelectCmd - just use Maya select directly with path string.

Comment on lines +137 to +138
@unittest.skipUnless(((ufeUtils.ufeFeatureSetVersion() >= 2) and (mayaUtils.previewReleaseVersion() >= 121)), 'testMayaSelectFlags only available in UFE v2 or greater and Maya Preview Release 121 or later.')
def testMayaSelectFlags(self):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New select test that tests all the various select command flags that are supported by UFE now.

Copy link
Collaborator

@ppt-adsk ppt-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent test, thanks for doing this!

@seando-adsk seando-adsk added requires maya This issue requires changes in Maya unit test Related to unit tests (both python or c++) labels Nov 16, 2020
@seando-adsk seando-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Nov 16, 2020
@kxl-adsk kxl-adsk merged commit 408f646 into dev Nov 16, 2020
@kxl-adsk kxl-adsk deleted the donnels/MAYA-107600/maya_select_command_now_supports_ufe branch November 16, 2020 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Development process is finished, PR is ready for merge requires maya This issue requires changes in Maya unit test Related to unit tests (both python or c++)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants