Reuse shader effect for duplicate material networks. #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huidong-chen
commented
Nov 30, 2020
huidong-chen
requested review from
kxl-adsk,
williamkrick and
JGamache-autodesk
kxl-adsk
approved these changes
Dec 1, 2020
williamkrick
approved these changes
Dec 1, 2020
JGamache-autodesk
requested changes
Dec 1, 2020
huidong-chen
force-pushed
the
chenh/MAYA-108261/reuse-shader-effect-for-duplicate-materials
branch
from
13990c2
to
59ac9e6
Compare
|
I have to rebase the branch so that it can compiled with latest UFE code. Aside from that, the new commit 59ac9e6 is to address the change proposed by @JGamache-autodesk . |
JGamache-autodesk
approved these changes
Dec 2, 2020
JGamache-autodesk
approved these changes
Dec 2, 2020
huidong-chen
added
the
ready-for-merge
|
@kxl-adsk Please merge. |
Reasons why I commit this change: * HdSceneDelegate::GetScenePrimPath() is not available on old USD versions. * Even if it is available in new USD versions, it is bad to query the scene scene paths in the render delegate code (which should only care about the render index paths). * The new approach calculates concise relative paths which not only avoids ambiguity but only allows better reuse of shader effects, e.g. the following two material networks will be able to share a shader effect: - file1/UVReader -> file1 -> surface1 - UVReader -> file1 -> surface1
|
Another commit for this PR: 528f2c1. Click the commit link to see the reasons please. |
huidong-chen
commented
Dec 3, 2020
| @@ -482,7 +503,7 @@ _LoadTexture(const std::string& path, bool& isColorSpaceSRGB, MFloatArray& uvSca | |||
| #if USD_VERSION_NUM >= 2102 | |||
| HioImageSharedPtr image = HioImage::OpenForReading(path); | |||
| #else | |||
| GlfImageSharedPtr image = GlfImage::OpenForReading(path); | |||
| GlfImageSharedPtr image = GlfImage::OpenForReading(path); | |||
There was a problem hiding this comment.
@kxl-adsk Any idea why github clang-format-linter doesn't like this change?
There was a problem hiding this comment.
It is one more mysterious mystery about clang format. I will revert this change anyway so we don't have to wait on it.
There was a problem hiding this comment.
I've logged the problem in the wiki.
JGamache-autodesk
approved these changes
Dec 3, 2020
kxl-adsk
deleted the
chenh/MAYA-108261/reuse-shader-effect-for-duplicate-materials
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a shader instance cache to allow reuse of shader effect for duplicate material networks.