remove dependencies on old Hydra texture system from hdMaya for USD releases after 20.11 #961
Conversation
|
@pmolodo: Could I bug you to have a look at this one when you get a chance? Just want to make sure we haven't missed anything here, since we don't make heavy use of mtoh ourselves. Thanks! |
There was a problem hiding this comment.
So, I haven't looked at the texture changes coming in 21.02 yet - is it the case that texture resource handling is handled more "automatically", and none of these overrides are required at all in order to get texture support? Or are these changes effectively just disabling texture support for now (until we can add it back in a way that's compatible with 21.02, later?)
I think it should be the former. I don't actually expect that there will be major changes needed to add support for 21.02, but just that vestiges of the old texture system are being removed, so we want to drop code in It looks like all of that is already in place in So my hope is that texture support should happily continue working, but I was hoping you could help verify that. :) |
mattyjams
force-pushed
the
pr/hdMaya_remove_dependencies_on_old_Hydra_texture_system
branch
from
886ecd9
to
2e1070f
Compare
|
Oh - if the changes are in 20.11, then why are most of the checks for <= 20.11? Shouldn't they be < 20.11? |
Good question. I don't think there's any particular reason why the deprecated API was left in for In any case, I rebased these changes and fixed up the |
|
If there's no benefit to supporting both APIs, then I think we should drop the old one in 20.11. That will make the code read better, mean the old stuff will get dropped sooner, and also make it easier for me to test (since I already have a pre-compiled 20.11, but haven't compiled the latest tip of dev yet!) |
…ersion 20.11 and later These functions are used by the old Hydra texture system and are no longer relevant with the new node-based material network setup in Hydra. (Internal change: 2127507)
…USD version 20.11 and later The HDMAYA_DELEGATE_GET_TEXTURE_RESOURCE and HDMAYA_DELEGATE_GET_TEXTURE_RESOURCE_ID debug codes are only used by GetTextureResource() and GetTextureResourceID(), which are removed for USD versions 20.11 and later.
…ter for core USD version 20.11 and later The "textureResource" light param is no longer relevant with the new Hydra texture system. (Internal change: 2127509)
…sion 20.11 and later (Internal change: 2127611)
mattyjams
force-pushed
the
pr/hdMaya_remove_dependencies_on_old_Hydra_texture_system
branch
from
2e1070f
to
7b65099
Compare
Cool, works for me! I just rebased and pushed that change. Let me know how your testing goes! Thanks! |
|
Ok, I built this and ran some basic tests, and it seems to be working fine! |
kxl-adsk
added
the
ready-for-merge
|
@pmolodo: Great, glad to hear it! Thank you, sir! |
mattyjams
deleted the
pr/hdMaya_remove_dependencies_on_old_Hydra_texture_system
branch
Our Hydra team is working on removing parts of the old Hydra texture system for the next core USD release.
With Luma's recent work, it looks like all of the necessary support for the newer material network-based system is already in place, so the changes here mostly just pre-process the old code away for USD releases after 20.11.