MAYA-106079 Skip Looks scopes #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip importing non-empty UsdScope that only contains UsdShade items.
mattyjams
approved these changes
Dec 8, 2020
lib/usd/translators/scopeReader.cpp
Outdated
Comment on lines
33
to
46
| // If this is a Looks/Materials scope that contains only UsdShade nodes, just skip. | ||
| bool hasLookData = false; | ||
| bool hasNonLookData = false; | ||
| for (auto const& child : usdPrim.GetChildren()) { | ||
| if (child.IsA<UsdShadeNodeGraph>() || child.IsA<UsdShadeShader>()) { | ||
| hasLookData = true; | ||
| } else { | ||
| hasNonLookData = true; | ||
| break; | ||
| } | ||
| } | ||
| if (hasLookData && !hasNonLookData) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Makes sense to me, but a few somewhat cosmetic notes:
- Though
Looksis unfortunately still the default for the material scope name, I think we'd like to transition away from using that term, and really we're just interested in finding anyUsdGeomScopeprims with authored scene description below them that is only shading information. - It might be a bit more robust to check whether the child prim is compatible with
UsdShadeConnectableAPIrather than looking specifically at its node graph-ness or shader-ness.
So with those two small tweaks, something like this?:
// If this scope contains only UsdShade nodes, just skip.
bool hasShadingData = false;
bool hasNonShadingData = false;
for (const auto& child : usdPrim.GetChildren()) {
if (UsdShadeConnectableAPI(child)) {
hasShadingData = true;
} else {
hasNonShadingData = true;
break;
}
}
if (hasShadingData && !hasNonShadingData) {
return false;
}
JGamache-autodesk
added
the
ready-for-merge
dj-mcg
added a commit
to dj-mcg/maya-usd
that referenced
this pull request
Feb 12, 2022
Fixes a bug where UsdLuxLight prims underneath a Scope were not being imported properly (if the Scope only had light prims underneath it). The import logic for "Scope" uses a heuristic to see if that scope is a "Looks" or "Materials" scope. It did this by checking if any of the children nodes were UsdShadeConnectableAPI. Unfortunately, lights (and other non-shading prims) can be UsdShadeConnectableAPI. This new heursistic checks for Material prims. Note, this was more or less the original version that Autodesk proposed in: Autodesk#985
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip importing non-empty UsdScope that only contains UsdShade items.