Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect anisotropy rotation specification #17

Closed
AdrienHerubel opened this issue Sep 1, 2021 · 0 comments · Fixed by #18
Closed

Incorrect anisotropy rotation specification #17

AdrienHerubel opened this issue Sep 1, 2021 · 0 comments · Fixed by #18
Assignees
@AdrienHerubel

Comments

@AdrienHerubel
Copy link
Collaborator

AdrienHerubel commented Sep 1, 2021 •
edited
Loading

The anisotropy rotation specification says :
orientation of anisotropy; range [0,1] (where 1 means 180 degrees)

Instead if should be :
orientation of anisotropy; range [0,1] (where 1 means 360 degrees)

The reference implementation implements the correct behavior.
@AdrienHerubel AdrienHerubel self-assigned this Sep 1, 2021
@AdrienHerubel AdrienHerubel linked a pull request Sep 1, 2021 that will close this issue
Fixes #17 Anisotropy rotation specification #18
Merged
iliyang added a commit that referenced this issue Sep 1, 2021
@AdrienHerubel @iliyang
Fixes #17 Anisotropy rotation specification (#18)
77a60a2 
* Fix anisotropy rotation specification

The anisotropy rotation specification should say that a value of 1 means 360 degrees not 180

* Bumped version (bugfix)

Co-authored-by: Iliyan Georgiev <iliyang@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdrienHerubel AdrienHerubel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #17 Anisotropy rotation specification AdrienHerubel/standard-surface
1 participant
@AdrienHerubel