Upgrade Import Modal #1008
Merged
Upgrade Import Modal #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no bim360 access warning is fine, still shows regular hubs
|
@PepperLola Appears to handle the BIM360 hubs now. UI is still a mess tho |
|
@PepperLola Instead of navigating the hubs, you might want to just search for |
PepperLola
requested review from
a-crowell and
LucaHaverty
and removed request for
a team
HunterBarclay
requested changes
Jul 10, 2024
Dhruv-0-Arora
approved these changes
Jul 12, 2024
Finally, yes |
BrandonPacewic
requested review from
BrandonPacewic
and removed request for
LucaHaverty
|
Trying to fix whatever the formatter is complaining about |
🫡 |
HunterBarclay
previously approved these changes
Jul 12, 2024
Comment on lines
1
to
-10
| /// <reference types="vite/client" /> | ||
|
|
||
| interface ImportMetaEnv { | ||
| readonly VITE_SYNTHESIS_SERVER_PATH: string | ||
| // more env variables... | ||
| } | ||
|
|
||
| interface ImportMeta { | ||
| readonly env: ImportMetaEnv | ||
| } |
There was a problem hiding this comment.
Do we still need to save this file?
There was a problem hiding this comment.
It was kept in prior to me using and we might use it in the future for other vite environment stuff, so I decided to keep it in for now.
BrandonPacewic
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Show cached and assetpack files in the Import Mira modal, and have an option to delete the individual cached assets. Improve the APS hub/project/file management ui and add a button to sign in if the user isn't already.
Objectives
Known issues to solve
Known issues to ignore for now
Important
Depends on #992 and #982
JIRA Issue