Convert to Absolute Imports [AARD-1737]
#1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
BrandonPacewic
changed the title
[AARD-1737]
BrandonPacewic
requested review from
PepperLola and
azaleacolburn
and removed request for
a team
BrandonPacewic
commented
Aug 6, 2024
There was a problem hiding this comment.
@HunterBarclay Looks like the formatter for the exporter broke. My best guess is that the version of isort that runs on linux is behaving differently than the one for mac and windows. Might just need to disable it for now.
All files in this PR are formatting correctly.
Edit:
Check #1081 for the fix.
Dhruv-0-Arora
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
general_imports.pyand all code that was running on some form ofimport *.cmdDefsinMarkingMenu.pywas not being reset, moving into an__init__structure made this obvious.__init__file to contain the global and saved state. This state will persist through restarts of the exporter.JIRA Issue