Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Fix in dev #1020

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Quick Fix in dev #1020

merged 3 commits into from
Jul 9, 2024

Conversation

Dhruv-0-Arora
Copy link
Collaborator

Description

Fixed syntax error coming from first transform gizmo branch in SceneRenderer that was causing the error with SceneObject casting in Scene.tsx
Missing function error from MainHUD in the God Mode function. Fixed in MirabufSceneObject.ts

@Dhruv-0-Arora Dhruv-0-Arora requested review from HunterBarclay and a team as code owners July 9, 2024 19:03
@Dhruv-0-Arora Dhruv-0-Arora requested review from PepperLola and azaleacolburn and removed request for a team July 9, 2024 19:03
Copy link
Member

@azaleacolburn azaleacolburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we may be getting a little too carless with our fixing of merge conflicts. I assume that is where these errors are coming from.

Good work.

@BrandonPacewic BrandonPacewic removed the request for review from PepperLola July 9, 2024 20:51
@BrandonPacewic BrandonPacewic added the hotfix Pull requests that should be resolved before the next snapshot/release label Jul 9, 2024
@HunterBarclay HunterBarclay merged commit 1cd2755 into dev Jul 9, 2024
11 of 12 checks passed
@HunterBarclay HunterBarclay deleted the dhruv/quick-fix branch July 9, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix Pull requests that should be resolved before the next snapshot/release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants