Build Errors #1029
Merged
Build Errors #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucaHaverty
requested review from
a-crowell and
Dhruv-0-Arora
and removed request for
a team
LucaHaverty
changed the title
| @@ -40,7 +39,7 @@ const ZoneConfigPanel: React.FC<PanelPropsImpl> = ({ panelId, openLocation, side | |||
| <NumberInput label="Points" placeholder="Zone points" defaultValue={1} onInput={v => setPoints(v || 1)} /> | |||
| <Checkbox label="Destroy Gamepiece" defaultState={false} onClick={setDestroy} /> | |||
| <Checkbox label="Persistent Points" defaultState={false} onClick={setPersistent} /> | |||
| <Slider | |||
| {/* <Slider | |||
There was a problem hiding this comment.
Note: Sliders being commented will be overridden by PR #1021
| @@ -22,11 +21,11 @@ const ZoneConfigPanel: React.FC<PanelPropsImpl> = ({ panelId, openLocation, side | |||
| // then set all default values to the state of the zone | |||
| const [, setName] = useState<string>("") | |||
| const [alliance, setAlliance] = useState<"red" | "blue">("blue") | |||
| const [, setParent] = useState<string>("") | |||
| const [,] = useState<string>("") | |||
There was a problem hiding this comment.
Note: Also going to be overriden by Zone Config PR
Dhruv-0-Arora
approved these changes
Jul 16, 2024
HunterBarclay
requested review from
PepperLola and
BrandonPacewic
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed build errors caused by preferences being of type 'object' and what I assume was a merge conflict to do with sliders