Initial Code Simulation Support: WebSocket Client #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le is making use of SyntheSimJava
HunterBarclay
requested review from
a-crowell,
Dhruv-0-Arora,
azaleacolburn and
LucaHaverty
and removed request for
a team
There was a problem hiding this comment.
Note: If you click WS test twice you run into a warning (the connection is not being closed I believe)
Also localhost connection is hardcoded (mine is 3000 not 3300) so it can't be in production
Dhruv-0-Arora
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Everything else looks good 👍
I think its more important that @Ewie21 and @PepperLola approve though
azaleacolburn
approved these changes
Jul 19, 2024
Comment on lines
+39
to
+42
| export const simMap = new Map<SimType, Map<string, any>>() | ||
|
|
||
| export class SimGeneric { | ||
| private constructor() {} |
There was a problem hiding this comment.
Should simMap be a static field on SimGeneric, since the latter encapsulates former?
There was a problem hiding this comment.
@PepperLola How ever you two end up structuring everything will determine this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is very bare bones and not meant to be user facing. This is simply getting the core technology into the project, so @PepperLola and @Ewie21 get on with their tasks.
JIRA Issue