Named robot controls #1034
Named robot controls #1034
Conversation
fission/src/Synthesis.tsx
Outdated
| @@ -96,7 +92,8 @@ function Synthesis() { | |||
| console.debug(`Selected Mirabuf File: ${mira_path}`) | |||
| } | |||
|
|
|||
| const setup = async () => { | |||
| // TODO: do we actually want to spawn a robot right away when synthesis loads? | |||
There was a problem hiding this comment.
No we don't, but it's just kinda stuck around from when I was testing physics
LucaHaverty
requested review from
a-crowell and
Dhruv-0-Arora
and removed request for
a team
|
Chorus detected one or more security issues with this pull request. See the Checks tab for more details. As a reminder, please follow the secure code review process as part of the Secure Coding Non-Negotiable requirement. |
| onAccept={() => { | ||
| PreferencesSystem.savePreferences() | ||
| InputSchemeManager.saveSchemes() | ||
| InputSystem.selectedScheme = undefined | ||
| }} |
There was a problem hiding this comment.
Could you delete the robot onCancel() so if the user cancels their input scheme then the robot doesn't spawn
There was a problem hiding this comment.
Would we maybe want them to be able to spawn a robot and not assign it a control scheme temporarily?
There was a problem hiding this comment.
@HunterBarclay @Dhruv-0-Arora Is this something we could add to brain config down the line?
Description
Adds names and name tags to robots to help the user distinguish between robots when configuring controls and other settings like intake/ejector. You can create completely custom input schemes, or edit the default ones. Deleting a customized version of a default input scheme will reset it, not completely remove it.
Objectives
Note
When testing, make sure to mess around with configuring intakes and ejectors because the way robot control info is stored changed, which could potentially create issues.
JIRA Issue