Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APS Required Login Fix #1065

Merged
merged 1 commit into from
Jul 30, 2024
Merged

APS Required Login Fix #1065

merged 1 commit into from
Jul 30, 2024

Conversation

BrandonPacewic
Copy link
Member

Fix an issue where APS login was always required, even if upload was not selected as the export location.

@BrandonPacewic BrandonPacewic self-assigned this Jul 30, 2024
@BrandonPacewic BrandonPacewic requested review from HunterBarclay and a team as code owners July 30, 2024 16:21
@BrandonPacewic BrandonPacewic requested review from PepperLola and azaleacolburn and removed request for a team July 30, 2024 16:21
Copy link
Member

@azaleacolburn azaleacolburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't believe we missed this

@BrandonPacewic
Copy link
Member Author

I can't believe we missed this

Yea... Me too...

Copy link
Member

@PepperLola PepperLola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Looking

@HunterBarclay HunterBarclay merged commit e5c12d1 into dev Jul 30, 2024
13 checks passed
@HunterBarclay HunterBarclay deleted the branp/aps-login-fix branch July 30, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants