Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving Import Local Mirabuf #1071

Merged
merged 6 commits into from
Aug 12, 2024
Merged

Moving Import Local Mirabuf #1071

merged 6 commits into from
Aug 12, 2024

Conversation

Dhruv-0-Arora
Copy link
Collaborator

@Dhruv-0-Arora Dhruv-0-Arora commented Jul 31, 2024

Description

Removed the "Import Local Mirabuf" from MainHUD and moved it to "Spawn Asset" panel.

Screenshot 2024-07-31 at 1 19 34 PM Screenshot 2024-07-31 at 1 20 25 PM

Note: Merge #1069 first

JIRA Issue

@Dhruv-0-Arora Dhruv-0-Arora added the gameplay Relating to the playability of Synthesis label Jul 31, 2024
@Dhruv-0-Arora Dhruv-0-Arora self-assigned this Jul 31, 2024
@Dhruv-0-Arora Dhruv-0-Arora requested review from HunterBarclay and a team as code owners July 31, 2024 20:20
@Dhruv-0-Arora Dhruv-0-Arora requested review from a-crowell and LucaHaverty and removed request for a team July 31, 2024 20:20
Copy link
Collaborator

@a-crowell a-crowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Make sure the control schemes panel still pops up upon uploading a robot.

@Dhruv-0-Arora Dhruv-0-Arora requested a review from a-crowell August 1, 2024 20:23
Copy link
Collaborator

@a-crowell a-crowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This helps with one of our pain points from beta day about mirabuf being confusing. Having everything under spawn asset is definitely better imo.

fission/src/ui/components/MainHUD.tsx Outdated Show resolved Hide resolved
@LucaHaverty
Copy link
Collaborator

Do you all think it looks better for the button to be at the bottom of the panel instead of under "saved assets"? I think it looks a bit cleaner at the bottom, but here's a comparison:

Under saved assets Bottom
image image

Also, maybe we could add an icon to the button kind of like this:
image

@Dhruv-0-Arora Dhruv-0-Arora mentioned this pull request Aug 8, 2024
7 tasks
Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ready to approve this once we decide what we want to do with Luca's suggestions.

#1071 (comment)

Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should wait to put this in until after #1068 since it will result in a merge conflict. Should be easier to fix in a smaller PR like this.

@BrandonPacewic BrandonPacewic self-requested a review August 9, 2024 20:56
@HunterBarclay HunterBarclay merged commit 3a20e92 into dev Aug 12, 2024
13 checks passed
@HunterBarclay HunterBarclay deleted the dhruv/1787/import-file-move branch August 12, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gameplay Relating to the playability of Synthesis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants