-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving Import Local Mirabuf #1071
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Make sure the control schemes panel still pops up upon uploading a robot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This helps with one of our pain points from beta day about mirabuf
being confusing. Having everything under spawn asset is definitely better imo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ready to approve this once we decide what we want to do with Luca's suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should wait to put this in until after #1068 since it will result in a merge conflict. Should be easier to fix in a smaller PR like this.
Note
- Waiting for Combined Configuration #1068.
Description
Removed the "Import Local Mirabuf" from MainHUD and moved it to "Spawn Asset" panel.
JIRA Issue