Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: blue border on toggle button groups #1072

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Bug: blue border on toggle button groups #1072

merged 2 commits into from
Aug 1, 2024

Conversation

LucaHaverty
Copy link
Collaborator

Description

Removed the default MUI blue border when hovering over toggle button groups

Screenshot 2024-07-31 140552

@LucaHaverty LucaHaverty added bug ui/ux Relating to user interface, or in general, user experience labels Jul 31, 2024
@LucaHaverty LucaHaverty self-assigned this Jul 31, 2024
@LucaHaverty LucaHaverty requested review from HunterBarclay and a team as code owners July 31, 2024 21:16
@LucaHaverty LucaHaverty requested review from a-crowell and Dhruv-0-Arora and removed request for a team July 31, 2024 21:16
a-crowell
a-crowell approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@a-crowell a-crowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful

Dhruv-0-Arora
Dhruv-0-Arora requested changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@Dhruv-0-Arora Dhruv-0-Arora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked to Luca irl and on my computer there is a green border around the selected one that shouldn't be there.
Screenshot 2024-07-31 at 2 45 15 PM

Dhruv-0-Arora
Dhruv-0-Arora approved these changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@Dhruv-0-Arora Dhruv-0-Arora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breathtaking 😮‍💨

@HunterBarclay HunterBarclay merged commit 3c2669d into dev Aug 1, 2024
13 checks passed
@HunterBarclay HunterBarclay deleted the haverty/bug/button-group-border branch November 10, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dhruv-0-Arora Dhruv-0-Arora Dhruv-0-Arora approved these changes

@a-crowell a-crowell a-crowell approved these changes

@HunterBarclay HunterBarclay Awaiting requested review from HunterBarclay HunterBarclay is a code owner

Assignees

@LucaHaverty LucaHaverty

Labels
bug ui/ux Relating to user interface, or in general, user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LucaHaverty @a-crowell @Dhruv-0-Arora @HunterBarclay