Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Barclay/JoltPhysics.js submodule #1086

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Conversation

BrandonPacewic
Copy link
Member

We still have mirabuf as a submodule even though we don't really need it anymore. It does however make the repo look cooler and just that much more complex. So why not also add Hunter's fork of jolt that we use? We don't really need it here, but it looks cool.

@BrandonPacewic BrandonPacewic self-assigned this Aug 8, 2024
@BrandonPacewic BrandonPacewic requested review from HunterBarclay and a team as code owners August 8, 2024 20:38
@BrandonPacewic BrandonPacewic requested review from PepperLola and Dhruv-0-Arora and removed request for a team August 8, 2024 20:38
@BrandonPacewic BrandonPacewic requested review from a-crowell, azaleacolburn and LucaHaverty and removed request for PepperLola August 8, 2024 20:48
Copy link
Member

@azaleacolburn azaleacolburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fully support this PR being merged

Copy link
Collaborator

@Dhruv-0-Arora Dhruv-0-Arora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Azalea supports then I do too

Copy link
Collaborator

@a-crowell a-crowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then, I do three.

@HunterBarclay HunterBarclay merged commit 3f06b09 into dev Aug 9, 2024
11 of 13 checks passed
@HunterBarclay HunterBarclay deleted the branp/hunters-favor branch August 9, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants