Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track Compiled Proto Files #1088

Merged
merged 7 commits into from
Aug 13, 2024
Merged

Track Compiled Proto Files #1088

merged 7 commits into from
Aug 13, 2024

Conversation

BrandonPacewic
Copy link
Member

Just one less step in getting the exporter up and running. We also need these files tracked to keep the formatter consistent between developer computers and the github action bot. Also also, this will be needed for adding type checking with mypy which I am currently working on.

@BrandonPacewic BrandonPacewic self-assigned this Aug 9, 2024
@BrandonPacewic BrandonPacewic requested review from HunterBarclay and a team as code owners August 9, 2024 21:53
@BrandonPacewic BrandonPacewic requested review from PepperLola and azaleacolburn and removed request for a team August 9, 2024 21:53
Copy link
Member

@HunterBarclay HunterBarclay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the README to match the current setup instructions. It still mentions the init script.

@HunterBarclay
Copy link
Member

HunterBarclay commented Aug 12, 2024

@BrandonPacewic When running the addin, it pops up with the dependency installation window, then it says the dependencies have been install successfully, and I need to restart. I restart, and then it repeats. It's done this 4 times in a row now. For context, I git cleaned my repo.

Copy link
Collaborator

@Dhruv-0-Arora Dhruv-0-Arora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sublime

@HunterBarclay HunterBarclay merged commit 309c287 into dev Aug 13, 2024
12 checks passed
@HunterBarclay HunterBarclay deleted the branp/track-proto-files branch August 13, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants