Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Continuity #1089

Merged
merged 18 commits into from
Aug 20, 2024
Merged

UI Continuity #1089

merged 18 commits into from
Aug 20, 2024

Conversation

LucaHaverty
Copy link
Collaborator

@LucaHaverty LucaHaverty commented Aug 12, 2024

Description

Cleaned up all of the UI and standardized it across the whole product.

Objectives

  • Tweak colors to be closer to what's on the figma
  • Remove access to the theme editor (sorry Julian, it's very cool but we don't have the time to fix it at the moment 😢)
  • Rename everything to be less technical and more accessible to young robotics students
  • Add tooltips on settings that users found confusing or misunderstood
  • Make UI more dynamic for a more enjoyable user experience (hover effects, click effect, etc...)
  • Fix the bug causing a robots scheme to not be set if it was selected while the robot was importing
  • Fix the scroll zoom bug

Note

I am not a visual designer and I think there is still a lot of room for improvement, so please comment on anything you think should change, no matter how big or small, both in the UI design and user experience.

Screenshots

(A little has changed since the screenshots were taken so definitely pull down the branch and mess around with it)

Tooltips

image

Settings Modal

Before After
image image

Spawn Asset Panel (demonstration of the new colors)

image

Dynamic UI Demo

Untitled.video.-.Made.with.Clipchamp.5.mp4

Questions for reviewers:

Important

Feedback I'm looking for:

  • I'm not a big fan of what I did with the accordion button, let me know if you have better ideas!
  • Do you all think the name "configure assets" and "general settings" will make sense to users lacking technical experience?
  • Do we want to keep debug tools in the build that is released? If so, we might want to add info tooltips to all of the options.
  • Should we keep sequential joints as a separate configuration interface than configuring motor speeds and torques or merge them?
  • Any suggestions for the intake, ejector, and scoring zone config panels?

Control scheme bug Jira issue
UI Fixes Jira issue
Info Buttons Jira issue
Scroll Zoom Bug Jira issue

@LucaHaverty LucaHaverty changed the title UI continuity UI Continuity Aug 12, 2024
@LucaHaverty LucaHaverty self-assigned this Aug 12, 2024
@LucaHaverty LucaHaverty added enhancement ui/ux Relating to user interface, or in general, user experience labels Aug 12, 2024
@LucaHaverty LucaHaverty marked this pull request as ready for review August 12, 2024 22:06
@LucaHaverty LucaHaverty requested review from HunterBarclay and a team as code owners August 12, 2024 22:06
@LucaHaverty LucaHaverty requested review from a-crowell and Dhruv-0-Arora and removed request for a team August 12, 2024 22:06
Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to keep debug tools in the build that is released? If so, we might want to add info tooltips to all of the options.

@HunterBarclay Are we going to have two separate urls up? One for release and one for dev?

If we have two versions up then I think we should add a tag that will remove it from prod builds, if not then perhaps we should just keep it for now.

fission/src/ui/components/MainHUD.tsx Outdated Show resolved Hide resolved
fission/src/ui/components/MainHUD.tsx Outdated Show resolved Hide resolved
fission/src/ui/components/MainHUD.tsx Show resolved Hide resolved
fission/src/ui/modals/configuring/SettingsModal.tsx Outdated Show resolved Hide resolved
fission/src/ui/panels/DebugPanel.tsx Show resolved Hide resolved
@a-crowell
Copy link
Collaborator

I'm not a big fan of what I did with the accordion button, let me know if you have better ideas!

Yeah something is a little off, but it's hard to tell what. This might be a simple icon change like to a simple arrow (>) instead.

Copy link
Collaborator

@a-crowell a-crowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧗

Co-authored-by: PepperLola <PepperLola@users.noreply.github.com>
@BrandonPacewic BrandonPacewic self-requested a review August 19, 2024 22:33
Co-authored-by: PepperLola <PepperLola@users.noreply.github.com>
Copy link
Collaborator

@Dhruv-0-Arora Dhruv-0-Arora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yummy

Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LucaHaverty This PR does not close AARD-1846. I realize that my issue title was definitely too general but the description describes a different problem.

@LucaHaverty
Copy link
Collaborator Author

@LucaHaverty This PR does not close AARD-1846. I realize that my issue title was definitely too general but the description describes a different problem.

@BrandonPacewic You're right. I think that should be addressed in another pr that addresses several other issues caused by the panel system, so I'm removing it from this one.

Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BrandonPacewic You're right. I think that should be addressed in another pr that addresses several other issues caused by the panel system, so I'm removing it from this one.

Awesome, I absolutely agree, just wanted to make sure that we kept track of the task. Nice work!

@LucaHaverty LucaHaverty merged commit 5bd353f into dev Aug 20, 2024
13 checks passed
@LucaHaverty LucaHaverty deleted the haverty/ui-continuity branch August 20, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ui/ux Relating to user interface, or in general, user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants