-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Dreaded ConfigCommand.py
Refactor [AARD-1764]
#1107
base: dev
Are you sure you want to change the base?
Conversation
* dev: (28 commits) Removed console logs Fixed all issues Debug lines canOPFS check Reverted change to settings modal Remove comment ¯\_(ツ)_/¯ reverted accidental sim changes Organized subsystem config differently Remove mass icons Better generationing and removing Generation fix Fix variable name typo Update conversion function typing Synthesis Exporter now tracks Fusion's unit system setting scaling fix Merge conflict fix Lots of documentation Remove old import add catch for no robot being avaliable Tooltips!!! ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the default export location change. Nice job getting it down to so few lines 🥇
One thing I noticed is that it no longer includes the version number in the exported file name. Not sure if this was intentional and I don't mind either way, just something to note.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing I noticed is that it no longer includes the version number in the exported file name. Not sure if this was intentional and I don't mind either way, just something to note.
Unfortunately, this was not intended. 🫤
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still works and includes the full name and version this time. I will say that previously it would only concatenate the name and version with an underscore and the rest would be the raw name with spaces (i.e. Utility Knife_v2.mira
instead of the Utility_Knife_v2.mira
that happens now). I don't care either way and this is definitely less important than including the version number and full name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will say that previously it would only concatenate the name and version with an underscore and the rest would be the raw name with spaces (i.e.
Utility Knife_v2.mira
instead of theUtility_Knife_v2.mira
that happens now). I don't care either way and this is definitely less important than including the version number and full name.
Yea this was on purpose. Was simpler to write it this way and I figured it was fine to replace all spaces with underscores.
I am happy to report that this file is now less than 240 lines. 😊
ConfigCommand.py
.PersistentEventHandler
class that will auto add a handler to the global list to keep it from falling out of scope.adsk.fusion.Design.cast(adsk.core.Application.get().activeProduct)
for the design getter call.JIRA Issue