Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HALSim websocket server only listens on localhost #1115

Merged
merged 3 commits into from
Jan 5, 2025

Conversation

virtuald
Copy link

@virtuald virtuald commented Jan 4, 2025

I personally haven't tried this (so you should verify before merging!) but the websocket server only listens on localhost, so that environment variable specified in build.gradle serves no purpose (it's a client setting, not a server setting).

Reference: https://github.com/wpilibsuite/allwpilib/blob/b65f159c3fdfdfce9ec126cf79dfd9a16d1e66e9/simulation/halsim_ws_server/src/main/native/cpp/HALSimWeb.cpp#L120

@virtuald virtuald requested review from HunterBarclay and a team as code owners January 4, 2025 19:04
@virtuald virtuald requested review from BrandonPacewic and Dhruv-0-Arora and removed request for a team January 4, 2025 19:04
@HunterBarclay HunterBarclay changed the base branch from prod to dev January 4, 2025 21:27
@HunterBarclay
Copy link
Member

@virtuald
Thanks for the catch. It looks like that's left over from native Synthesis where we actually handled the server and the user used the client extension. I have a PR ready for your branch which removes the use of this environment variable from our sample projects.

HALSim Websocket Server Environment Variable Cleanup
@HunterBarclay HunterBarclay merged commit 7a7c2a1 into Autodesk:dev Jan 5, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants