Fusion Selection Bug #954
Merged
Fusion Selection Bug #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HunterBarclay
requested review from
a-crowell,
BrandonPacewic,
PepperLola and
LucaHaverty
as code owners
|
This PR has been user tested and confirmed to work (both the installer and the bug fix). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Users were unable to select joints and occurrences when choosing wheel joints and game pieces.
Cause
API changed the order in which event handlers were assessed and executed, resulting in the
InputChangedEventHandlerbeing executed before theSelectionEventHandler. This resulted in the selections being clear viaself.reset(), and therefore caused there to be no selection for theSelectionEventHandler.Fix
Removed the
self.reset()calls when a selection is made and instead cleared selections when the add buttons are pressed.Notes
Also fixed a bug where the preselection cursor didn't work for joints, as well as fixed the preselection cursor so it actually sits on top of where your cursor really is.