Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Components #976

Merged
merged 18 commits into from
Jun 20, 2024
Merged

UI Components #976

merged 18 commits into from
Jun 20, 2024

Conversation

PepperLola
Copy link
Member

@PepperLola PepperLola commented Jun 18, 2024

Converted many components to use the MUI (Base) library.

Changes

  • Converted to customized MUI components for better functionality and accessibility
  • Block interactions behind modals (and add click-away listener to close the modal)
  • Customizable starting positions and side padding for panels
  • Fixed panel background/height
  • Configured formatter and formatted all files

JIRA Issue

@PepperLola PepperLola self-assigned this Jun 18, 2024
@PepperLola PepperLola requested a review from a team as a code owner June 18, 2024 20:59
@PepperLola PepperLola requested review from HunterBarclay and a-crowell and removed request for a team June 18, 2024 20:59
@autodesk-chorus
Copy link

Chorus detected one or more security issues with this pull request. See the Checks tab for more details.

As a reminder, please follow the secure code review process as part of the Secure Coding Non-Negotiable requirement.

Copy link
Member

@HunterBarclay HunterBarclay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter isn't happy. I fixed some that were automatic but there are a few left I'll leave up to you.

@HunterBarclay
Copy link
Member

@PepperLola Some new error when running build:

src/components/SelectButton.tsx:53:17 - error TS2322: Type '{ value: string; colorClass: string | undefined; size: ButtonSize | undefined; onClick: () => void; className: string | undefined; }' is not assignable to type 'IntrinsicAttributes & ButtonProps'.
  Property 'colorClass' does not exist on type 'IntrinsicAttributes & ButtonProps'.

53                 colorClass={selecting ? "bg-background-secondary" : colorClass}
  

@BrandonPacewic BrandonPacewic added the ui/ux Relating to user interface, or in general, user experience label Jun 19, 2024
@HunterBarclay HunterBarclay self-requested a review June 19, 2024 18:23
Copy link
Member

@HunterBarclay HunterBarclay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@PepperLola PepperLola requested a review from LucaHaverty June 19, 2024 20:33
Copy link
Collaborator

@a-crowell a-crowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@HunterBarclay HunterBarclay merged commit 2f598c9 into dev Jun 20, 2024
14 checks passed
@HunterBarclay HunterBarclay deleted the jwrigh/1669/ui-components branch June 20, 2024 23:05
@HunterBarclay HunterBarclay restored the jwrigh/1669/ui-components branch June 21, 2024 03:32
@HunterBarclay HunterBarclay deleted the jwrigh/1669/ui-components branch June 21, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux Relating to user interface, or in general, user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants