-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input Manager #977
Input Manager #977
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works pretty well (except for the slider I think). I think something about the keybind detection needs to change to work on Mac though. When doing Shift + 1 it instead registers as Shift + !, and with alt it becomes Alt + ¡ rather than detecting the base key (1) and the modifier (Shift). I can rebind the controls to Alt + ¡ and it'll work properly, although it seems that joint 2 on the default TMM 2018 robot doesn't do anything and joint 3 controls both stages of the elevator.
It also looks like either the joint inputs aren't updating (maybe since they're being categorized as global?) or they're being added to robots that shouldn't have them, because when only Dozer is loaded I still see the arm and slider joints from the TMM 2018 bot.
…dings (ex: shift+1 -> shift+!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the multibot issues (controlling all robots simultaneously and controls from other robots showing up) which sounds like it will be solved later--looks great!
Someday:
- The stages of the 2471 elevator could have less impact on each other (they can move each other almost min to max), but the elevator fix commit was still a huge improvement and seems good enough for now.
- Shift/alt/ctrl combos don't do anything. Easily fixed by not using them, so again, future problem.
Looking over this was super impressive. Great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modifier keys still don't seem to work. Shift + 1
originally worked but after rebinding, no modifier keys responded (with or without)
Could you give me exact steps to recreate? I haven't been able to get modifier keys to not work, but Ayla seems to have found some issues with them too. |
if (this._accum) { | ||
this._wheelRotationAccum += this._wheel.GetAngularVelocity() * deltaT; | ||
this._wheelRotationAccum += 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why'd you remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure what it did and removed it while debugging wheel behavior, but I just now added it back in my most recent commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LucaHaverty K, looks like when you added it back, you accidentally pasted in the entire line again. Fixed it just now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Found a lot of little bugs with this one, so that's always good too.
Description
An input management system that can control Synthesis using both keyboard and controller with customizable. Some controls are global and some are robot specific. The input manager works with new behavior scripts to move robots.
Objectives
(the wacky slider joint behavior is fixed in Elevator Bug)
JIRA Issue