Skybox #991
Merged
Skybox #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dhruv-0-Arora
requested review from
PepperLola and
BrandonPacewic
and removed request for
a team
BrandonPacewic
added
the
rendering
HunterBarclay
requested changes
Jun 25, 2024
|
Resolved all changes |
There was a problem hiding this comment.
Some minor clarifying points. When you get the chance try to resolve the merge conflicts (unless @HunterBarclay does it for you 🙃). If you need any help with that feel free to grab me!
removed redundant variables in fragment & vertex glsl files removed redundant uTime from code (previously used for moving clouds) Deleted useful code fragments that were commented out uncommented mirabuf
|
@HunterBarclay @BrandonPacewic do the changes to skybox fix everything for you? |
HunterBarclay
approved these changes
Jun 28, 2024
| /* | ||
| * Updates the skybox colors based on the current theme | ||
|
|
||
| * @param currentTheme: current theme from ThemeContext.useTheme() |
There was a problem hiding this comment.
Probably best to have this than not. I would prefer that we standardize whether or not we want these kinds of doc strings at some point but that's a moot point anyways.
Looks good to me!
BrandonPacewic
approved these changes
Jul 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created a spherical skybox using glsl shaders. The skybox is currently implemented in the SceneRenderer.ts file and uses the glsl shaders located in @/shaders. In /public/ there is the custom starry_sky.png used to create the stars. These will most likely be removed or changed.
Key Features:
Warning
The renderer for the robot has been commented out in this code. There are also numerous changes to the tsconfig & vite config.
JIRA Issue