Vitest Playwright #996
Merged
Vitest Playwright #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HunterBarclay
added
enhancement
physics
HunterBarclay
requested review from
a-crowell and
Dhruv-0-Arora
and removed request for
a team
|
Waiting on #990 |
@a-crowell Yes, partly. We can ignore it in #990 for right now. |
|
@a-crowell @PepperLola @Dhruv-0-Arora Can you verify that you can run unit tests with no errors? Note an extra setup command that I'm about to add to the readme and package.json: This installs the playwright browsers. |
PepperLola
reviewed
Jun 27, 2024
exporter/SynthesisFusionAddin/src/Parser/SynthesisParser/Joints.py
Outdated
Show resolved
Hide resolved
… still runs on the browser tho.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've been bouncing around the issue of vitest running node, when we have a web app. This PR adds playwright, to run both the development server and a headless browser for running unit tests to avoid issues of node environment compilation.
Motivation
I need to update Jolt Physics and something in the recent releases changed, such that it uses a
new URL()call for getting the path to a file. This causes issues because vitest in a jsdom environment transformsnew URL()calls to usinghttp://paths, and if we use the node environment, we lose access to things like thewindow.Physics Memory
This should have a new version of the Jolt Physics package that enables memory growth and maybe increases the default size.