Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code for latest occwl version #13

Merged
merged 5 commits into from
May 25, 2022
Merged

Conversation

JoeLambourne
Copy link
Contributor

Why?

In #11 and #12 we see that updates to the occwl library introduced breaking changes which were not spotted in the example notebooks. Thank you to @cteqeu for reporting the issues and @akashaero for sharing the workaround.

This PR addresses the problems

What?

  • A new version of occwl is released see here. We now fix the version of occwl to this version to avoid further unexpected breakage.
  • In jupyter_segmentation_viewer.py we remove the calls to the removed functions.
  • All the notebooks are rerun and retested.
  • Some warnings were firing in pytorch-lightning. To ensure that all metrics are computed correctly we pass the number of faces to the logger as the batch size. Notice that the IoU and accuracy metrics reported in the paper are per-face rather than per solid.
  • In scale_utils.py we make use of the scaling function in occwl rather than re-implementing it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant