Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dependency check script #108

Merged
merged 6 commits into from
Jan 6, 2019

Conversation

mukkachaitanya
Copy link
Collaborator

Requirements

  • Need for managing the outdated dependencies easily.

Description of the Change

Adds dependency-check script to take care of outdated dependencies.

Benefits

Know and update outdated dependencies faster.

Applicable Issues

Addresses #107

@codecov
Copy link

codecov bot commented Dec 16, 2018

Codecov Report

Merging #108 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #108   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files          24       24           
  Lines         688      688           
=======================================
  Hits          683      683           
  Misses          5        5
Flag Coverage Δ
#integration 94.91% <ø> (ø) ⬆️
#unit 99.27% <ø> (ø) ⬆️
Impacted Files Coverage Δ
lib/controller/prefs.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6de73c...2e3c43f. Read the comment docs.

@mukkachaitanya mukkachaitanya mentioned this pull request Dec 27, 2018
@prasadtalasila
Copy link
Member

@mukkachaitanya Suprised that I did not receive notification regarding your update on this PR. Two suggestions:

  1. Updates to travis setup
    Please update the travis build environment to Ubuntu Xenial 16.04. For an example, see .travis.yml. The travis environment also allows us to select a version of Node.js using nvm. See the example. If not already done, it is time to update your local development environment to the Node.JS 10.x LTS.
  2. The travis build log shows a few unused dependencies: codeclimate-test-reporter, coveralls and mock-stdin. If these dependencies are not being used, please remove them from package.json and update the package-lock.json.

.travis.yml Outdated
language: node_js
node_js:
- "8"

install:
- npm install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukkachaitanya The npm gets installed and managed via nvm.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, sir, I need that parameter?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I mean is that the npm install command may not be required at all.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Understood sir.

@prasadtalasila prasadtalasila merged commit 126035d into AutolabJS:dev Jan 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants