-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added dependency check script #108
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #108 +/- ##
=======================================
Coverage 99.27% 99.27%
=======================================
Files 24 24
Lines 688 688
=======================================
Hits 683 683
Misses 5 5
Continue to review full report at Codecov.
|
Minor changes to prefs controller
a95d3a2
to
52c3448
Compare
@mukkachaitanya Suprised that I did not receive notification regarding your update on this PR. Two suggestions:
|
.travis.yml
Outdated
language: node_js | ||
node_js: | ||
- "8" | ||
|
||
install: | ||
- npm install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mukkachaitanya The npm gets installed and managed via nvm
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, sir, I need that parameter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I mean is that the npm install
command may not be required at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Understood sir.
Requirements
Description of the Change
Adds
dependency-check
script to take care of outdated dependencies.Benefits
Know and update outdated dependencies faster.
Applicable Issues
Addresses #107