Validation module

lib/controller/prefs.js

@@ -2,14 +2,20 @@ const prefsInput = require('../cli/input/prefs');
 const prefsOutput = require('../cli/output/prefs');
 const prefsModel = require('../model/prefs');
 
+const validator = require('./validation');
+
 const onPrefs = async (args, options, logger) => {
   logger.moduleLog('info', 'Prefs', 'Prefs command invoked for');
   logger.moduleLog('info', 'Prefs', args.preference);
-  let changePrefEvent = await prefsInput.getInput(args, options);
-  logger.moduleLog('debug', 'Prefs', 'Event for the prefs command called');
-  logger.moduleLog('debug', 'Prefs', changePrefEvent);
-  changePrefEvent = await prefsModel.storePrefs(changePrefEvent);
-  prefsOutput.sendOutput(changePrefEvent);
+  if (validator.prefs(args, options)) {
+    let changePrefEvent = await prefsInput.getInput(args, options);
+    logger.moduleLog('debug', 'Prefs', 'Event for the prefs command called');
+    logger.moduleLog('debug', 'Prefs', changePrefEvent);
+    changePrefEvent = await prefsModel.storePrefs(changePrefEvent);
+    prefsOutput.sendOutput(changePrefEvent);
+  } else {
+    logger.moduleLog('error', 'Prefs', 'Invalid command');
+  }
 };
 
 const addTo = (program) => {

lib/controller/validation.js

@@ -0,0 +1,27 @@
+const prefsOutput = require('../cli/output/prefs');
+
+const supportedServers = ['ms', 'gitlab'];
+const supportedCommand = ['show', 'changelang', 'changeserver', 'logger'];
+
+const prefs = (args, options) => {
+  if (supportedCommand.indexOf(args.preference) === -1) {
+    prefsOutput.sendOutput({ name: 'invalid_command' });
+    return false;
+  }
+  if (args.preference === 'changeserver') {
+    if (options.type && supportedServers.indexOf(options.type) === -1) {
+      prefsOutput.sendOutput({
+        name: 'invalid_server',
+        details: {
+          supportedServers,
+        },
+      });
+      return false;
+    }
+  }
+  return true;
+};
+
+module.exports = {
+  prefs,
+};

test/unit/lib/controller/prefs.js

@@ -8,6 +8,7 @@ const prefsInput = require('../../../../lib/cli/input/prefs');
 const prefsOutput = require('../../../../lib/cli/output/prefs');
 const prefsModel = require('../../../../lib/model/prefs');
 const prefsController = require('../../../../lib/controller/prefs');
+const validator = require('../../../../lib/controller/validation');
 
 chai.use(sinonChai);
 chai.should();
@@ -25,13 +26,15 @@ describe('For prefs controller', function () {
   });
 
   it('should call the prefs action of program with right arguments when command is valid', testPrefsValid);
+  it('should exits the program when command is invalid', testPrefsInvalid);
 });
 
 /* eslint-disable max-lines-per-function */
 function testPrefsValid(done) {
   const mockprefsInput = sandbox.mock(prefsInput);
   const mockprefsOutput = sandbox.mock(prefsOutput);
   const mockprefsModel = sandbox.mock(prefsModel);
+  const mockValidator = sandbox.mock(validator);
 
   const testMsPort = 8999;
 
@@ -48,6 +51,9 @@ function testPrefsValid(done) {
   }).resolves(changedPrefs);
   mockprefsModel.expects('storePrefs').withExactArgs(changedPrefs).resolves(changedPrefs);
   mockprefsOutput.expects('sendOutput').withExactArgs(changedPrefs);
+  mockValidator.expects('prefs').withExactArgs({ preference: 'changeserver' }, {
+    type: 'ms', host: 'abc', port: '8999', lang: undefined, maxsize: undefined, blacklist: undefined,
+  }).returns(true);
 
   prefsController.addTo(program);
 
@@ -61,6 +67,27 @@ function testPrefsValid(done) {
     mockprefsInput.verify();
     mockprefsOutput.verify();
     mockprefsModel.verify();
+    mockValidator.verify();
+    done();
+  }, 0);
+}
+
+function testPrefsInvalid(done) {
+  const mockValidator = sandbox.mock(validator);
+  mockValidator.expects('prefs').withExactArgs({ preference: 'changeserver' }, {
+    type: 'github', host: 'abc', port: '8999', lang: undefined, maxsize: undefined, blacklist: undefined,
+  }).returns(false);
+
+  prefsController.addTo(program);
+
+  program.exec(['prefs', 'changeserver'], {
+    type: 'github',
+    host: 'abc',
+    port: '8999',
+  });
+
+  setTimeout(() => {
+    mockValidator.verify();
     done();
   }, 0);
 }

test/unit/lib/controller/validation.js

@@ -0,0 +1,68 @@
+const chai = require('chai');
+const sinon = require('sinon');
+const sinonChai = require('sinon-chai');
+
+const validator = require('../../../../lib/controller/validation');
+const prefsOutput = require('../../../../lib/cli/output/prefs');
+
+chai.should();
+chai.use(sinonChai);
+
+const sandbox = sinon.createSandbox();
+
+describe('for validation', function () {
+  afterEach(function () {
+    sandbox.restore();
+  });
+
+  it('should return true on correct command', testValidCommand);
+  it('should call prefs output with correct arguments on invalid command', testInvalidPrefsCommand);
+  it('should call prefs output with correct arguments on invalid server', testInvalidServer);
+});
+
+function testValidCommand(done) {
+  const testArgs = {
+    preference: 'changeserver',
+  };
+  const testOptions = {
+    type: 'ms',
+  };
+
+  validator.prefs(testArgs, testOptions).should.be.equal(true);
+  done();
+}
+
+function testInvalidPrefsCommand(done) {
+  const mockprefsOutput = sandbox.mock(prefsOutput);
+  const testArgs = {
+    preference: 'represent',
+  };
+
+  mockprefsOutput.expects('sendOutput').withExactArgs({ name: 'invalid_command' });
+
+  validator.prefs(testArgs).should.be.equal(false);
+  mockprefsOutput.verify();
+  done();
+}
+
+function testInvalidServer(done) {
+  const mockprefsOutput = sandbox.mock(prefsOutput);
+  const testArgs = {
+    preference: 'changeserver',
+  };
+  const testOptions = {
+    type: 'github',
+  };
+  const supportedServers = ['ms', 'gitlab'];
+
+  mockprefsOutput.expects('sendOutput').withExactArgs({
+    name: 'invalid_server',
+    details: {
+      supportedServers,
+    },
+  });
+
+  validator.prefs(testArgs, testOptions).should.be.equal(false);
+  mockprefsOutput.verify();
+  done();
+}