Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added check if variable name empty or not #443

Merged
merged 1 commit into from
May 21, 2024
Merged

added check if variable name empty or not #443

merged 1 commit into from
May 21, 2024

Conversation

zahin178
Copy link
Collaborator

PR Type

Bug Fix

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made.
  • Version number has been updated.
  • Required modules have been added to respective "requirements*.txt" files.
  • Relevant Test Cases added to this description (below).
  • (Team) Label with affected action categories and semver status.

Overview

Previously even if we didn't provide any variable name for the OCR actions that were extracting some texts and saving them into a vriable the action passed successfully which was a bug. Now I have added the check to see, if the variable name is empty then it will throw an error

if var_name == "":
        CommonUtil.ExecLog(
                sModuleInfo, "Please provide a variable name to store the extracted value", 3
            )
        return "zeuz_failed"

This check has been added to the following functions

  • ocr_get_value_with_coordinates
  • ocr_get_value_with_image
  • ocr_get_value_with_text

Test Cases

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
pradyunsg Pradyun Gedam
@sazid sazid merged commit a1e6724 into dev May 21, 2024
1 check passed
@sazid sazid deleted the ocr_actions branch May 21, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants