Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against PHP 8.2, and maybe 8.3 #745

Closed
GaryJones opened this issue Jan 27, 2023 · 2 comments · Fixed by #750
Closed

Test against PHP 8.2, and maybe 8.3 #745

GaryJones opened this issue Jan 27, 2023 · 2 comments · Fixed by #750

Comments

@GaryJones
Copy link
Contributor

What problem would the enhancement address for VIP?

PHP 8.2 is released, and we should check how VIPCS works with it, even though WordPress itself doesn't yet support PHP 8.2.

Describe the solution you'd like

Add 8.2 to the test.yml matrix. We'll also want to use dev-develop version of WPCS as well.

Also, add 8.3 as an include, but allow it to be experimental.

@jrfnl
Copy link
Collaborator

jrfnl commented Jan 27, 2023

💯 Was thinking the same yesterday when reviewing #742, but didn't want to pollute the issue with unrelated remarks.

@jrfnl
Copy link
Collaborator

jrfnl commented Jan 27, 2023

Notes about PHPCS vs 8.2:

  • PHP 8.2 doesn't introduce a huge amount of syntax changes, so is nowhere near as problematic as some of the previous PHP releases.
  • PR to support readonly classes is open and expected to be merged in PHPCS 3.8.0.
  • Follow up PR to add support for readonly classes to various sniffs has been prepared.
  • Big "still to do": add Tokenizer support for DNF (mixing intersection and union types and using parentheses in types - will probably mean that a new T_OPEN_TYPE_PARENS token will need to be introduced (and similar for close parens).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants