Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show/Hide company logo File Upload button #2569

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Conversation

mikeyarce
Copy link
Member

Fixes #2294

The issue was that when you uploaded a Company Logo, you still had the prompt of "No File Selected" which can appear confusing as you just uploaded a file.

Changes proposed in this Pull Request

  • When you upload a Company Logo, the upload button and max file size is hidden
  • If you remove the company logo you just added, it becomes visible

Testing instructions

  • Go to Post a Job
  • Add a company logo
  • Verify that the file upload button and the Max File size is gone
  • Remove logo
  • Verify that the button and file size is back

Screenshot / Video

company_logo

@mikeyarce mikeyarce requested a review from a team August 29, 2023 22:56
Copy link
Contributor

@yscik yscik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"No file selected" when selecting a valid image as Company Logo in Job Listing
2 participants