Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly pass popup config to javascript #173

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Correctly pass popup config to javascript #173

merged 1 commit into from
Jan 26, 2023

Conversation

psrpinto
Copy link
Member

Fixes #171

@psrpinto psrpinto requested a review from akirk January 26, 2023 16:42
@psrpinto
Copy link
Member Author

psrpinto commented Jan 26, 2023 •
edited
Loading

Merging to issue a hotfix release.

@psrpinto psrpinto merged commit 37989a6 into main Jan 26, 2023
@psrpinto psrpinto deleted the fix-popup branch January 26, 2023 16:53
@psrpinto psrpinto mentioned this pull request Jan 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akirk akirk Awaiting requested review from akirk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Popup does not use configured settings
1 participant
@psrpinto