tagging wpcs's latest commit as dependency in composer #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psrpinto
approved these changes
Feb 13, 2023
Member
psrpinto
left a comment
psrpinto
left a comment
There was a problem hiding this comment.
👍 Should we create a ticket to upgrade to new wpcs version once it's released?
need to do this because we are using sanitize_url() which has been marked as undeprecated but a new PHPCS release isn't out
ashfame
force-pushed
the
phpcs_need_latest_develop
branch
from
4560074 to
056fe51
Compare
Member
Author
|
I don't think we need to track that in an issue. Would get to update it eventually the next time need arises :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to do this because we are using
sanitize_url()in #184 which has been marked as un-deprecated but a new PHPCS release isn't outFixed in PHPCS but would only be released in PHPCS v3