Always register the admin filters #215
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, I do see the admin page on v0.7.1 on a WP install under a subdir
I am not sure we should do this to make Chatrix work on "WP in browser via wasm". IMO, there would be other plugins commonly doing this exact sort of thing & right fix would be in "WP in browser via wasm" codebase, no? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On installs where the
wp-adminis not in/, the settings screen is empty (see https://wpgp.kirk.at/?lang=de&plugin=chatrix). This is because we do some premature optimization to not register the filters.By removing that optimization, the settings load also in the above case.