Make it possible to disable service worker at runtime #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psrpinto
changed the title
psrpinto
force-pushed
the
disable-service-worker
branch
from
e672c25
to
f6057d0
Compare
|
@psrpinto Am I right in assuming Chatrix would gracefully fallback without the service worker and still work, just the multiple instances on a page bit won't be handled? |
|
Correct, it works fine without the service worker, as long as there is only one instance of hydrogen running for a given session. The only thing the service worker does is to close the session on the "active" instance whenever the same session is opened in another instance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By setting
enableServiceWorker: falsein block attributes.