-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove JP Constants #24
Conversation
This page could still be useful for sandboxing APIs even with latest stable Jetpack, |
Yeah, I wasn't sure if we would want to say "just install the beta plugin, but still run stable, to mess with constants" or keep the file with conditionals in one/both places. Up to you boss. |
I'd just remove the beta blocks piece and leave the page here. I think I've only used sandboxing with stable Jetpack so far. |
I've sandboxed with beta versions, like testing out something like Automattic/jetpack#9802 before the wpcom side was deployed. I've switched it out so that JN's version won't display if the beta plugin is active. As I left it, there's a corner case where if you've set constants with the beta plugin disabled, then enable the beta plugin, you're stuck unable to change constants (since we have the tamper function load without a hook and companion will load first). If this route is an acceptable compromise to you, I can explore a way to juggle them better. |
Awesomeness. Merging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added to the beta plugin in Automattic/jetpack-beta#72 (when/if merged).
I could see the rationale in keeping it here for times Jetpack is installed without the beta plugin, but can reset the PR to only return early if so desired.