Fix: Give each attribute in Edit Flow settings page a different id #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natebot
requested changes
May 20, 2021
Contributor
natebot
left a comment
natebot
left a comment
There was a problem hiding this comment.
Left a note asking about the nonce validation.
| echo ' value="' . __( 'Disable', 'edit-flow' ) . '" />'; | ||
| echo '</p>'; | ||
| wp_nonce_field( 'change-edit-flow-module-nonce', 'change-module-nonce', false ); | ||
| wp_nonce_field( 'change-edit-flow-module-nonce', 'change-module-nonce-' . $mod_data->slug, false ); |
Contributor
There was a problem hiding this comment.
What does this name change mean for validating the nonce?
Contributor
There was a problem hiding this comment.
nm, I see the nonce doesn't change based on name.
Member
Author
There was a problem hiding this comment.
nm, I see the nonce doesn't change based on name.
Yeah, that's right. The change-edit-flow-module-nonce action for wp_nonce_field and wp_verify_nonce is still the same.
natebot
approved these changes
May 20, 2021
Member
Author
|
Thanks @natebot :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #631
Description
This PR is pretty simple. It's simply to use
slugof each module and append it to the current name/id.Steps to Test
Found 8 elements with non-unique id #change-module-nonceerror in your browser console.change-module-nonce, there will be 8 results with a different suffix.