Skip to content

Conversation

@htdat
Copy link
Member

@htdat htdat commented Jun 11, 2021

Fix #663


Description

All research has been done in #663

Steps to Test

  1. Apply this PR.
  2. Apply the diff in the Note section for edit_flow.php to avoid caching issue for JS files Fix jQuery warnings as WordPress upgraded it from 1.12.4-wp to 3.5.1 #649
  3. Visit wp-admin > Dashboard > Story Budget.

✅ if we can change Screen Options, click actions for posts, etc without any issue.

@htdat htdat requested a review from mikeyarce June 11, 2021 09:28
Copy link
Contributor

@mikeyarce mikeyarce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@htdat htdat merged commit 2f9d9f5 into master Jun 14, 2021
@htdat htdat deleted the fix/663 branch June 14, 2021 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

jQuery - redundant code in modules/story-budget/lib/story-budget.js

3 participants