Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Basic code maintenance improvements #1099

Merged
merged 6 commits into from
Oct 6, 2022
Merged

Basic code maintenance improvements #1099

merged 6 commits into from
Oct 6, 2022

Commits on Oct 6, 2022

  1. Update plugin version number to indicate beta 

    Helps with debugging
    @GaryJones
    GaryJones committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    73d01ef View commit details
    Browse the repository at this point in the history

  2. Simplify require_once statements

    @GaryJones
    GaryJones committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    faf218c View commit details
    Browse the repository at this point in the history

  3. Update PHP version check code 

    Move the function inside the conditional, update the function prefix, and change from PHP 5.4 to PHP 7.1
    @GaryJones
    GaryJones committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    92d1f45 View commit details
    Browse the repository at this point in the history

  4. Split workflows and move add_*() calls 

    Removes the redundant `else` that covered most of the file.
Moves the `add_()` and similar calls to just above the callback function and related DocBlock if there is one.
    @GaryJones
    GaryJones committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    79dc0c5 View commit details
    Browse the repository at this point in the history

  5. Move constants higher 

    - The `defined()` guard will stop misleading fatal errors if the file is accessed directly.
- Switch some define() to `const` - see https://www.linkedin.com/pulse/php-difference-between-define-constant-ankit-vishwakarma/ for why.
    @GaryJones
    GaryJones committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    9fb6e36 View commit details
    Browse the repository at this point in the history

  6. Simplify use of constants

    @GaryJones
    GaryJones committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    87560d4 View commit details
    Browse the repository at this point in the history