Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global constants file #195

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"dev:npm:css:main": "node-sass src/form.scss | postcss --config postcss.config.json -u autoprefixer -u postcss-custom-properties --no-map -o targets/npm/happychat.css",
"dev:npm:css:woo": "node-sass src/ui/css/themes/_woo.scss | postcss --config postcss.config.json -u autoprefixer -u postcss-custom-properties --no-map -o targets/npm/woo.css",
"dev:npm:css:jpop": "node-sass src/ui/css/themes/_jpop.scss | postcss --config postcss.config.json -u autoprefixer -u postcss-custom-properties --no-map -o targets/npm/jpop.css",
"dev:npm:serve-css": "NODE_ENV=development webpack-dev-server --config webpack.npm.config.js",
"dev:npm:css:serve": "NODE_ENV=development webpack-dev-server --config webpack.npm.config.js",

"dev:wordpress": "run-p dev:wordpress:*",
"dev:wordpress:js": "NODE_ENV=development webpack-dev-server --config webpack.wordpress.config.js",
Expand Down
11 changes: 11 additions & 0 deletions src/constants.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
// Auth strategies
export const AUTH_TYPE_WPCOM_OAUTH_BY_TOKEN = 'wpcom-oauth-by-token';
export const AUTH_TYPE_WPCOM_PROXY_IFRAME = 'wpcom-proxy-iframe';

// Layouts
export const LAYOUT_FULLSCREEN = 'fullscreen';
export const LAYOUT_PANEL = 'panel';

// Entry
export const ENTRY_CHAT = 'chat';
export const ENTRY_FORM = 'form';
5 changes: 1 addition & 4 deletions src/form.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { connect } from 'react-redux';
*/
import config from 'src/config';
import authenticator from 'src/lib/auth';
import { ENTRY_FORM } from 'src/constants';

// actions
import {
Expand Down Expand Up @@ -62,9 +63,6 @@ import CompactCard from 'src/ui/components/card/compact';
import FormLabel from 'src/ui/components/form-label';
import SpinnerLine from 'src/ui/components/spinner-line';

const ENTRY_FORM = 'form';
const ENTRY_CHAT = 'chat';

class ChatComponent {
constructor( props ) {
this.props = props;
Expand Down Expand Up @@ -422,4 +420,3 @@ const mapDispatch = {
};

export default connect( mapState, mapDispatch )( mockLocalize( Form ) );
export { ENTRY_FORM, ENTRY_CHAT };
2 changes: 1 addition & 1 deletion src/lib/auth/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import debugFactory from 'debug';
import {
AUTH_TYPE_WPCOM_OAUTH_BY_TOKEN,
AUTH_TYPE_WPCOM_PROXY_IFRAME,
} from './strategies';
} from 'src/constants';
import WPcomOAuth from './strategies/wpcom/oauth';
import WPcomProxyIframe from './strategies/wpcom/proxy-iframe';

Expand Down
6 changes: 0 additions & 6 deletions src/lib/auth/strategies/index.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,5 @@
/** @format */

/**
* Constants representing allowed and implemented authentication strategies
*/
export const AUTH_TYPE_WPCOM_OAUTH_BY_TOKEN = 'wpcom-oauth-by-token';
export const AUTH_TYPE_WPCOM_PROXY_IFRAME = 'wpcom-proxy-iframe';

/**
* "Abstract" class representing a base strategy, it should be extended by implemented strategies
* as a fail safe that all exposed methods are implemented.
Expand Down