Skip to content

Commit

Permalink
Duplicated views: add untangled comments to include list (#40649)
Browse files Browse the repository at this point in the history
* Added the comments page to the list of untangled pages under the experiment

* changelog

* Added notice to the comments section

* We now use the clean title

* Improved image

* Edited and improved image

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12409617595

Upstream-Ref: Automattic/jetpack@129f0de
  • Loading branch information
rcrdortiz authored and matticbot committed Dec 19, 2024
1 parent 21af2ba commit 4e47d9f
Show file tree
Hide file tree
Showing 6 changed files with 91 additions and 87 deletions.
58 changes: 29 additions & 29 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions vendor/automattic/jetpack-mu-wpcom/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
This is an alpha version! The changes listed here are not final.

### Added
- Added the comments page to the list of untangled pages under the experiment
- CSS Tidy: add css rule mask to allowlist
- Remove duplicate views: Show notices
- WordPress.com Features: add Holiday Snow functionality.
Expand Down
Binary file not shown.
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ function ( $location ) {
'tools.php?page=advertising',
'edit.php?post_type=jetpack-portfolio',
'edit.php?post_type=jetpack-testimonial',
'edit-comments.php',
'edit-tags.php?taxonomy=category',
'edit-tags.php?taxonomy=post_tag',
);
Expand Down Expand Up @@ -477,10 +478,12 @@ function wpcom_show_removed_calypso_screen_notice() {
wp_set_script_translations( $handle, 'jetpack-mu-wpcom', Jetpack_Mu_Wpcom::PKG_DIR . 'languages' );

global $title;
$config = wp_json_encode(
$clean_title = preg_replace( '/\(\d+\)/', '', $title );
$clean_title = trim( $clean_title );
$config = wp_json_encode(
array(
'imageUrl' => plugins_url( 'screens/' . sanitize_title( $current_screen ) . '.webp', __FILE__ ),
'title' => $title,
'title' => $clean_title,
'screen' => $current_screen,
'ajaxUrl' => admin_url( 'admin-ajax.php' ),
'dismissNonce' => wp_create_nonce( 'wpcom_dismiss_removed_calypso_screen_notice' ),
Expand Down
Loading

0 comments on commit 4e47d9f

Please sign in to comment.