Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiled gallery block captions #11794

Open
simison opened this issue Dec 28, 2018 · 93 comments
Open

Tiled gallery block captions #11794

simison opened this issue Dec 28, 2018 · 93 comments
Assignees
Labels
[Block] Tiled Gallery Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Tiled Gallery A different way to display image galleries on your site, in different organizations and shapes. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Interaction #] > 10 (Automated) interaction count label for better visibility. Please don't add these manualliy. [Pri] High [Size] M [Status] Design In Progress [Status] Needs Design [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@simison
Copy link
Member

simison commented Dec 28, 2018

Tiled gallery block currently doesn't have captions directly in the block interface.

It could have captions very similar to core gallery block. They have several issues and bugs we should solve before shipping captions to our customers.

This is a list of all the issues, bugs and problems around captions so that it's easier to re-design how captions should work.

Screenshots are from the time when captions were actually implemented in Tiled gallery; they were just taken out just before releasing the block because of several issues.

  • Links in captions look awful (Tiled gallery block: styles for links in captions wp-calypso#29729)

  • Longer captions cover "remove image" button in the editor (Repo Gardening: update triage tasks (wording and Slack notifications) #29706)

  • Captions don't look great on small tiles. We need to rethink how we adjust caption text size when tiles scale down for small screens. Captions in a tile might look great on desktop but then the gallery looks awful on mobile.

  • Writing captions for circle layout doesn't work.
    We had to disable captions for circle layout because, well:

  • Captions are automatically pulled in from image meta. It's easy enough to just not write captions, but cleaning out automatically added captions from a lot of images, especially on smaller screens is really annoying or impossible:

  • Users might expect captions to appear only on mouse hover, just like with old tiled gallery. That isn't too amazing with touchscreens, though.

  • Detecting if caption is empty using RichText.isEmpty() is buggy. Calypso-Gutenberg seems to pass an old version of RichText format (array) and our block expects new format (string), thus making it seem like caption isn't empty, causing caption UI to behave weirdly and causing block invalidations on save. We need to RichText.toHTMLString( caption )

  • Adding files from Media picker wipes out previously added captions (Gutenlypso: Opening Media Library Breaks Image Blocks wp-calypso#29557, p7jreA-21M-p2)


cc @MichaelArestad @scruffian @mapk

@simison
Copy link
Member Author

simison commented Dec 28, 2018

Perhaps functioning MVP version of captions could be:

  • No rich text, just plain text
  • Edit them via sidebar (and move them back to the block area when we've designed better UI for it)
  • Don't auto-import captions from image meta
  • Scale down text size on small screen or container width
  • Still no captions for circles or center captions horizontally

That doesn't give amazing caption-editing experience but solves majority of issues.

@gaelgerard
Copy link

Hello,

I'm looking to display tiled gallery image captions in order to display them in the lightbox after the user clicks on it.

In fact as you noticed, the placement of the caption is not easy that's why i would certainly choose not to display them at all on the gallery but only on click.

CSS is my friend but not for every wp user and that's why I understand you don't want to publish this functionnality again at the moment. (it's working on tiled galleries in classic mode but not in gtbg)

Perhaps the solution could be to add a checkbox for the user to display the caption or not in the gallery. So that the user is responsible for the bad design and can eventually edit his caption to fit in place.

Concerning the MVP above, I would prefer auto-import captions from image meta as it as always been done. I don't want to edit every image from every galleries from every websites I manage to copy/paste existing captions.

In classic mode, Tiled galleries display caption but breaks my layout. I have to replace them with gtbg bloc galleries but then no more caption on my images 😥

Can you please tell me if there will be a release soon or if i should look another way to achieve my goal?

Thank you for your help

Gaël

@molszewska
Copy link

Just got one report and I've tested that captions in Tiled Gallery Block do not appear on hover (as I'd expect them to do). They do appear only after clicking the image, in the slideshow.

This can be remedied with adding the gallery within Classic Block.

@gaelgerard
Copy link

Unfortunately, in classic mode, the tiled gallery breaks my layout.

I think it's due to the inlined width of the gallery but I didn't look further since the gtbg bloc tiled gallery fits just fine.

For now, I will use wp default galleries when I need Captions to be shown and beautifull tiled galleries when it's less important.

Thanks for your help

@scruffian
Copy link
Member

Here's my take on how to handle these issues:

  • For the links, I suggest we match the text colour of links to the rest of the text, and underline the link

  • For circle tiles I suggest we centre the text on the tile both horizontally and vertically

  • I think we need a couple of block settings, one which enables/disables captions and another which pulls captions from image meta (or not)

  • I think there's a good case for matching the design of the old tile galleries in terms of the text size, alignment, and background. That should make it simpler to convert old galleries to new ones.

  • I also like the idea of only showing the captions on hover. Perhaps on mobile we could use a "swipe left" interaction to simulate hover, which would bring the caption in?

  • The captions covering the "remove image" button in the editor looks like a core issue. It would be great if someone submitted a patch for that.

The other issues sound like technical concerns not design ones.

cc @thomasguillot, i'd love your thoughts on this

@thomasguillot
Copy link
Contributor

Here's what I would do:

  • Like @scruffian said, match the text colour of links to the rest of the text, and underline it.
  • Maybe we could offer a (plain) background and colour option and have it default to what we currently have (black gradient + white)
  • Automatically truncate the caption (e.g. if height > 50% of parent.height)
  • Add a caption setting
  • Potentially force the setting to be disabled when using the Circle Tiles -- I think it's OK if 1 style doesn't support captions as I'm not sure about having it horizontally and vertically centred; it would obfuscate the image.
  • I also like the idea of the hover on desktop. Maybe hide it on touch+small screen and always display it on touch+larger screen.

@scruffian
Copy link
Member

Automatically truncate the caption (e.g. if height > 50% of parent.height)

Would this make the rest of the caption impossible to read?

@thomasguillot
Copy link
Contributor

Automatically truncate the caption (e.g. if height > 50% of parent.height)

Would this make the rest of the caption impossible to read?

It would but the caption would still be available when a visitor clicks and opens the carousel.

@scruffian
Copy link
Member

It would but the caption would still be available when a visitor clicks and opens the carousel.

Good point, I like this idea :)

@simison simison transferred this issue from Automattic/wp-calypso Apr 1, 2019
@simison simison added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Tiled Gallery A different way to display image galleries on your site, in different organizations and shapes. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Apr 1, 2019
@jenhooks
Copy link

jenhooks commented May 5, 2019

As of today, I'm not seeing captions showing up at all. See live here: https://jenwpjm.mystagingwebsite.com/testing-jetpack-tiled-gallery-captions/

Reported in 2009353-zen. Based on Automattic/wp-calypso#30014 -- sounds like this is something that is already known?

@matticbot matticbot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label May 5, 2019
@simison
Copy link
Member Author

simison commented May 6, 2019 via email

@RCowles
Copy link
Contributor

RCowles commented May 8, 2019

@simison thanks for clarifying! We received a report that captions no longer appear underneath the full-size image in Carousel. I was able to repro here:
https://ryancowles.mystagingwebsite.com/2019/05/tiled-gallery-block/

Note in the above example, each image has a Title, Description, Caption, and Alt Text value. Only the Title and Description fields show in Carousel.

Is this related/expected behavior as well?

@simison
Copy link
Member Author

simison commented May 9, 2019

I'm not quite sure how carousel picks those up — @jeherve would you be more familiar with Carousel?

@jeherve
Copy link
Member

jeherve commented May 9, 2019

Yep, that's a known issue / byproduct of how the gallery blocks store their data:
#11594 (comment)

@RCowles
Copy link
Contributor

RCowles commented May 9, 2019

Thank you both for the additional context! Please feel free to close this issue as you see fit.

@simison simison changed the title Tiled gallery block: issues with captions Tiled gallery block captions May 17, 2019
@formosattic
Copy link

User request in #2056566-zen.

@cecoates
Copy link

User requested: #9543186-hc

@samiff
Copy link
Contributor

samiff commented Jul 9, 2019

Reported in 2166921-zen

Noting that the current documentation still mentions hover-over captions as a feature.

@simison
Copy link
Member Author

simison commented Jul 10, 2019

Noting that the current documentation still mentions hover-over captions as a feature.

Thanks for the heads up!

p1562740031135900-slack-jpop-quill

@TrovenTrip
Copy link

TrovenTrip commented Feb 13, 2021

Hi all, I've come across this thread while trying to add captions to my Jetpack tiled gallery blocks. Looks like there's been some good work on it so far, but nothing posted since July 2020. Just wondering if this is still being looked at? I'm happy to help with any beta testing on my site if/when a solution reaches that stage.
Thanks

@creativecoder
Copy link
Contributor

Hi @TrovenTrip! I don't think anyone is actively working on this, specifically. There's related work on the image gallery block in WordPress Core. The hope is that once that approach is proven, the same approach could be copied in the Tiled Gallery block. This would bring with it all the standard image block controls (including captions).

@noteeth
Copy link

noteeth commented Mar 1, 2021

Another request for captions in Tiled gallery
3782362-zen
27450396-hc

@Robertght
Copy link

Another request in 3785382-zen

@swoodipto
Copy link

Another report in 27450396-hc
Follow up at 3782362-zen

@tmmbecker
Copy link

3788256-zen

@aleone89
Copy link

Another request for this has been made here: https://wordpress.com/forums/topic/find-pictures-captions-in-my-slider/

@kelasante
Copy link

Another request 28495746-hc

@lizkarkoski
Copy link

Another request from the forums today: https://wordpress.com/forums/topic/captions-13/
suggested they use the regular gallery block as a work around for now.

@retnonindya
Copy link

retnonindya commented Apr 12, 2021

Request from a user on chat:
28274850-hc

I suggested them to use regular Gallery block. We also discussed the possibility of using third-party plugin to display captions on tiled gallery-look.

@supernovia
Copy link

A request here for some control over gallery captions:
https://wordpress.com/forums/topic/galleries-out-of-control/

They'd like them to not show over the images, but show in the carousel view.

@katiebethbrown
Copy link

User expected captions to display on Tiled gallery block. Suggested they transform to core gallery instead.

29385594-hc

@msilbers
Copy link

requested in 30174287-hc
Recommended the core Gallery block instead

@retnonindya
Copy link

Another request:
30460629-hc

I suggested them to use core Gallery block

@Robertght
Copy link

New request in 30514763-hc

@metabreakr
Copy link

4133913-zen
Recommended the core Gallery block instead

@danjjohnson
Copy link

@tmmbecker
Copy link

Several Newspack publishers have asked about this. They love the tiled gallery but don't love that there are no captions :/

@daria2303
Copy link

30884014-HC requested here too

@rickmgithub
Copy link

User not seeing captions on the tiled gallery - 4194585-zd
Seems to appear on desktop but not mobile.

@mikeicode
Copy link

Requested 31215860-hc

@mikeicode
Copy link

Another 31230051-hc

@kspilarski
Copy link

33575554-hc

@mxhassani
Copy link

Another one: 5372601-zd-woothemes

@filipanoscampos
Copy link

Another one:
5905506-zd-woothemes

@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2023

Support References

This comment is automatically generated. Please do not edit it.

@pehaa
Copy link

pehaa commented Mar 8, 2023

@github-actions github-actions bot added the [Interaction #] > 10 (Automated) interaction count label for better visibility. Please don't add these manualliy. label Mar 8, 2023
@erricgunawan
Copy link

+1 for my own personal request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Tiled Gallery Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Tiled Gallery A different way to display image galleries on your site, in different organizations and shapes. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Interaction #] > 10 (Automated) interaction count label for better visibility. Please don't add these manualliy. [Pri] High [Size] M [Status] Design In Progress [Status] Needs Design [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

No branches or pull requests