Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map Block: Map Theme buttons lack styling #14058

Closed
pento opened this issue Nov 18, 2019 · 3 comments · Fixed by #14072
Closed

Map Block: Map Theme buttons lack styling #14058

pento opened this issue Nov 18, 2019 · 3 comments · Fixed by #14072
Assignees
@pento
Labels
[Block] Map [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Type] Bug When a feature is broken and / or not performing as intended [Type] Good First Bug
Milestone
8.0

Comments

@pento
Copy link
Contributor

pento commented Nov 18, 2019

Note: This is not reproducible in WordPress 5.3, it requires the latest Gutenberg plugin.

Steps to reproduce the issue

  1. Activate the Gutenberg plugin.
  2. Create a new post in the block editor.
  3. Add a Map block.
  4. Observe that the "Map Theme" buttons in the sidebar lack the correct styling.

What I expected

The Map Theme buttons should preview each theme.

What happened instead

Plain text buttons are shown, instead.

Screenshots

WordPress 5.3:

Gutenberg 6.9.0:
@pento pento added [Type] Bug When a feature is broken and / or not performing as intended [Type] Good First Bug [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Block] Map labels Nov 18, 2019
@scottsweb
Copy link
Contributor

Screenshot 2019-11-18 at 12 56 37

Just tested this on the master branch with a fresh mapbox account and it seems to working well. Can you see if the images are being blocked at all by something in your browser or network (only thing I think it could be).

@pento
Copy link
Contributor Author

pento commented Nov 18, 2019

@scottsweb: Gutenberg master, or Jetpack master? It's definitely broken with Gutenberg master, regardless of the Jetpack version.

The bug is caused by WordPress/gutenberg#17880, which changed the class name which should be used in extensions/blocks/map/map-theme-picker/style.scss from edit-post-settings-sidebar__panel-block to block-editor-block-inspector.

@pento pento mentioned this issue Nov 18, 2019
Merged
@pento pento self-assigned this Nov 18, 2019
@pento pento added this to the 8.0 milestone Nov 18, 2019
@scottsweb
Copy link
Contributor

I tested Jetpack master not Gutenberg which explains the difference :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pento pento

Labels
[Block] Map [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Type] Bug When a feature is broken and / or not performing as intended [Type] Good First Bug
Projects
None yet
Milestone
8.0
Development

Successfully merging a pull request may close this issue.

Map Block: Fix the Map Theme selector style in Gutenberg 6.7+ Automattic/jetpack
2 participants
@pento @scottsweb