Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map Block: Fix the Map Theme selector style in Gutenberg 6.7+ #14072

Merged
merged 1 commit into from
Nov 19, 2019

Conversation

pento
Copy link
Contributor

@pento pento commented Nov 18, 2019

WordPress/gutenberg#17880 landed in Gutenberg 6.7, which changed a class name that the Map block depended on for the Map Theme selector.

Fixes #14058.

Changes proposed in this Pull Request:

Add an additional class selector to the Map Theme CSS, so that it will work with the block editor in WordPress Core, and Gutenberg.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

Bug fix.

Testing instructions:

  • Install and activate the Gutenberg plugin.
  • Add a Map block.
  • Check that the Map Theme options show the mini preview images.
  • Confirm that it appears the same when the Gutenberg plugin is deactivated.

Screenshots:

Before

After

Proposed changelog entry for your changes:

  • Map Block: Fixed display of the Map Theme selector in Gutenberg 6.7+.

@pento pento added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Block] Map labels Nov 18, 2019
@pento pento added this to the 8.0 milestone Nov 18, 2019
@pento pento requested a review from a team November 18, 2019 22:40
@pento pento self-assigned this Nov 18, 2019
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello pento! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D35637-code before merging this PR. Thank you!

@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: November 19, 2019.
Scheduled code freeze: November 12, 2019

Generated by 🚫 dangerJS against 1160a04

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Nov 19, 2019
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work well for me. 👍

@pento pento merged commit 5c6798b into master Nov 19, 2019
@pento pento deleted the fix/14058-map-block-theme-style branch November 19, 2019 21:47
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Map [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map Block: Map Theme buttons lack styling
4 participants