Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eventbrite Block: Add alignment options for modal button #14505

Closed
creativecoder opened this issue Jan 29, 2020 · 0 comments · Fixed by #14817
Closed

Eventbrite Block: Add alignment options for modal button #14505

creativecoder opened this issue Jan 29, 2020 · 0 comments · Fixed by #14817
Assignees
@apeatling
Labels
[Block] Eventbrite [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@creativecoder
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The modal embed for the Eventbrite block displays as a button, but does not have alignment options.

Describe the solution you'd like

Add the standard alignment options to the block for modal embeds

Screen Shot 2020-01-28 at 19 47 15
@creativecoder creativecoder added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Pri] Normal [Block] Eventbrite labels Jan 29, 2020
@apeatling apeatling self-assigned this Feb 26, 2020
apeatling added a commit that referenced this issue Feb 26, 2020
@apeatling
Eventbrite Alignment: Add left, center, right alignment support to th…
aca8baa 
…e Eventbrite block. Fixes #14505
@apeatling apeatling mentioned this issue Feb 26, 2020
Merged
scruffian added a commit that referenced this issue Mar 5, 2020
@scruffian
Eventbrite Block: Add alignment support (#14817)
bf3e4cc 
* Eventbrite Alignment: Add left, center, right alignment support to the Eventbrite block. Fixes #14505

* Eventbrite Alignment: Add position relative to block to make sure that the iframe cannot be interacted with when alignment is set. See #14820

* Eventbrite Alignment: Make sure the alignment classes are added to the server side rendered iframe embed.

* Use the block_classes helper function and escape the result

* Update the CSS to target the new class name

* Add support for wide and full alignments

Co-authored-by: Ben Dwyer <ben@scruffian.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apeatling apeatling

Labels
[Block] Eventbrite [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Eventbrite Block: Add alignment support Automattic/jetpack
2 participants
@apeatling @creativecoder