Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscriptions block: handle connected and subscribed states on WordPress.com #15649

Closed
jeherve opened this issue May 1, 2020 · 2 comments
Closed
Assignees
Labels
[Block] Subscriptions [Closed] Duplicate Duplicate of an existing issue. [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@jeherve
Copy link
Member

jeherve commented May 1, 2020

This is a follow-up for #15107.

In testing D40775-code, I realized that we can have a big difference between the look of the block in the editor and the block on site, for logged in users (like the admins) and folks already subscribed.

The block may look like this on the frontend:
image

Even though you may have spent some time customizing the block in your editor:

image

You won't get to see those changes on the frontend of your site though, because you're logged in.

I am not sure how / if this should be addressed.

cc @apeatling

@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Pri] Normal [Block] Subscriptions labels May 1, 2020
@apeatling
Copy link
Member

apeatling commented May 14, 2020

I think the UI needs to be retained on the front end in all circumstances, possibly with an extra message below to denote subscribed status.

Once this is merged on WordPress.com I'll address this.

@jeherve
Copy link
Member Author

jeherve commented Jan 11, 2021

Closing as duplicate of #15474.

@jeherve jeherve closed this as completed Jan 11, 2021
@jeherve jeherve added the [Closed] Duplicate Duplicate of an existing issue. label Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Subscriptions [Closed] Duplicate Duplicate of an existing issue. [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

No branches or pull requests

2 participants