Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscriptions Block: Improve different states #15474

Closed
alaczek opened this issue Apr 17, 2020 · 2 comments · Fixed by #18550
Closed

Subscriptions Block: Improve different states #15474

alaczek opened this issue Apr 17, 2020 · 2 comments · Fixed by #18550
Assignees
Labels
[Block] Subscriptions [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@alaczek
Copy link
Contributor

alaczek commented Apr 17, 2020

The blog subscription block has four states depending on visitors being logged in/out and subscription status.

subscribe_block_states

Yet in the editor you can only see the logged-out state, with no easy way of previewing or changing other states.

image

Describe the solution you'd like

At the very least it would be great to have alignment option for other states - as seen in the example above things look particularly bad if a heading/text above the subscription block is centered.

@alaczek alaczek added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Block] Subscriptions labels Apr 17, 2020
@apeatling
Copy link
Member

I've noticed this too after working on #15076. I'm inclined to show the email form to all users and simply pre-fill the email field with the dotcom account email address. The states once subscribed could definitely be cleaned up.

@alaczek
Copy link
Contributor Author

alaczek commented Aug 11, 2020

I'm inclined to show the email form to all users and simply pre-fill the email field

Yes, I think this is a great idea! That lonely Subscribe button looks really off most of the time.
Here are some examples:

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Subscriptions [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants